-
Notifications
You must be signed in to change notification settings - Fork 776
missing capture_parameters in instrumentation psycopg #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
missing capture_parameters in instrumentation psycopg #3676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add a CHANGELOG entry
b30ad9c
to
6eabb29
Compare
@xrmx added changelog as requested. |
@StefanoOvus please run |
8f6bd0d
to
ec2d85b
Compare
@xrmx done |
There is a typecheck failure but I don't think it's related to changes made in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
ec2d85b
to
b99746f
Compare
Description
Added missing parameter
capture_parameters
for psycopg instrumentation:populates the
db.statement.parameters
attribute in spans.Fixes #3569
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests for sync and async connection:
instrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegration::test_span_params_attribute
instrumentation/opentelemetry-instrumentation-psycopg/tests/test_psycopg_integration.py::TestPostgresqlIntegrationAsync::test_span_params_attribute
Tested in a small script with Python 3.13.3 + jaegertracing/jaeger:2.6.0 docker image (OTLP/gRPC protocol).
tox -e py313-test-instrumentation-psycopg
tox -e spellcheck
tox -e lint-instrumentation-psycopg
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.