Skip to content

profiles: remove default_sample_type #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

profiles: remove default_sample_type #679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a13103f
profiles: remove default_sample_type
felixge Jul 10, 2025
8d89279
Merge branch 'main' into push-rnmukzywmwrs
tigrannajaryan Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ message ProfilesData {
// from non-containerized processes.
// Other resource groupings are possible as well and clarified via
// Resource.attributes and semantic conventions.
// Tools that visualize profiles should prefer displaying
// resources_profiles[0].scope_profiles[0].profiles[0] by default.
repeated ResourceProfiles resource_profiles = 1;

// One instance of ProfilesDictionary
Expand Down Expand Up @@ -182,10 +184,6 @@ message ScopeProfiles {
// https://opentelemetry.io/docs/specs/otel/schemas/#schema-url
// This schema_url applies to all profiles in the "profiles" field.
string schema_url = 3;

// The preferred type and unit of Samples in at least one Profile.
// See Profile.sample_type for possible values.
ValueType default_sample_type = 4;
}

// Profile is a common stacktrace profile format.
Expand Down