call auto configure listener with declarative config #7654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (76.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7654 +/- ##
============================================
- Coverage 90.01% 90.00% -0.01%
- Complexity 7093 7095 +2
============================================
Files 803 803
Lines 21462 21472 +10
Branches 2093 2093
============================================
+ Hits 19319 19326 +7
- Misses 1477 1480 +3
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkwatson
reviewed
Sep 15, 2025
| maybeRegisterShutdownHook(fromFileConfiguration.getOpenTelemetrySdk()); | ||
| OpenTelemetrySdk openTelemetrySdk = fromFileConfiguration.getOpenTelemetrySdk(); | ||
| maybeRegisterShutdownHook(openTelemetrySdk); | ||
| callAutoConfigureListeners(spiHelper, openTelemetrySdk); |
There was a problem hiding this comment.
Can we write a simple test to verify this happens?
There was a problem hiding this comment.
that turned out to be very helpful - it didn't work before...
zeitlinger
force-pushed
the
declarative-config-auto-config-listener
branch
from
c9ff575 to
df5c3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.