Skip to content

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 4, 2025

Alternative to #7418 that

  • does not expose resource more than it already is - as part of AutoConfiguredOpenTelemetrySdk
  • does not create resource twice

Fixes open-telemetry/opentelemetry-java-instrumentation#14325

@zeitlinger zeitlinger requested a review from a team as a code owner September 4, 2025 11:00
@zeitlinger zeitlinger self-assigned this Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.00%. Comparing base (2a92794) to head (5f388fb).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...leconfig/AutoConfiguredOpenTelemetrySdkAccess.java 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7639      +/-   ##
============================================
- Coverage     90.01%   90.00%   -0.01%     
- Complexity     7091     7100       +9     
============================================
  Files           803      804       +1     
  Lines         21443    21463      +20     
  Branches       2092     2093       +1     
============================================
+ Hits          19302    19318      +16     
- Misses         1477     1480       +3     
- Partials        664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative config: extract Resource correctly
1 participant