Library readmes - batch 3 #14680
Merged
Library readmes - batch 3 #14680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 tasks
laurit
reviewed
Sep 18, 2025
Comment on lines
43
to
47
| Mono<String> mono = Mono.just("Hello, World!"); | ||
| Flux<String> flux = Flux.just("Hello", "World"); | ||
|
|
||
| mono.subscribe(System.out::println); | ||
| flux.subscribe(System.out::println); |
There was a problem hiding this comment.
not really useful as the instrumentation won't change the outcome of this
laurit
reviewed
Sep 18, 2025
| import ratpack.server.RatpackServer; | ||
| import ratpack.http.client.HttpClient; | ||
|
|
||
| public class RatpackExample { |
There was a problem hiding this comment.
I personally like the okhttp code snippet more where we have a method that accepts opentelemety instance and returns instrumented client.
laurit
reviewed
Sep 18, 2025
| OpenTelemetry openTelemetry = ...; | ||
|
|
||
| // Create an instrumenter for your specific request type | ||
| Instrumenter<String, Void> instrumenter = Instrumenter.<String, Void>builder( |
There was a problem hiding this comment.
I get the feeling that this ins't a proper library instrumentation but rather a tool used in other instrumentations.
There was a problem hiding this comment.
yea, i'll switch to considering this an "internal" instrumentation and remove this readme entirely
jaydeluca
force-pushed
the
library-batch3
branch
from
ef1a60f to
d6c98e7
Compare
laurit
approved these changes
Sep 24, 2025
mznet
pushed a commit
to mznet/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6947