Configure Renovate #6459
Configure Renovate #6459
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Port changes from #6446.
github-actions
bot
added
infra
Not supported here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6459 +/- ##
==========================================
+ Coverage 86.62% 86.72% +0.10%
==========================================
Files 258 258
Lines 11878 11878
==========================================
+ Hits 10289 10301 +12
+ Misses 1589 1577 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
- Code analysers need extra work to upgrade. - Newer xunit packages do not support `net462`.
Fix accidental downgrade.
Directory.Packages.props
Outdated
| <PackageVersion Include="OpenTelemetry" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTelemetry.Api" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTelemetry.Api.ProviderBuilderExtensions" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTelemetry.Exporter.InMemory" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTelemetry.Extensions.Propagators" Version="[$(OTelLatestStableVer),)" /> | ||
| <PackageVersion Include="OpenTracing" Version="[0.12.1,)" /> |
There was a problem hiding this comment.
This is main concern on from my side. Other are minors.
"[$(OTelLatestStableVer),)" is not the same as "[$(OTelLatestStableVer),2.0)". It will allow to solve packages also with OpenTelemetry v2.0.0 if ever released.
Directory.Packages.props
Outdated
| <PackageVersion Include="Microsoft.CSharp" Version="[4.7.0]" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2]" /> | ||
| <PackageVersion Include="Microsoft.CSharp" Version="4.7.0" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2,)" /> |
There was a problem hiding this comment.
This should work the same as:
| <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2,)" /> | |
| <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.11.0-beta1.23525.2" /> |
There was a problem hiding this comment.
The change is semantically equivalent, but makes it fall into the regex used in the renovate configuration file which makes it "pinned" and be ignored. There's commentary in the abandoned PR detailing the rationale behind various choices here.
I've tried to upgrade this dependency previously, and it was non trivial as new rules made the build fail. This makes it ignored until someone actively tries to upgrade it manually. Renovate or dependabot would just generate a broken PR.
| <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.9.0" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.9.0-beta.1" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.9.0" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.9.0" /> |
There was a problem hiding this comment.
I think that we have 1.12.0 packages already. I am fine with keeping as is in this PR, and allow to fix it by renovate.
There was a problem hiding this comment.
Yeah I just unpinned it to let the PRs flow from dependabot. You can see in the description of this PR what updates are going to flow post-merge.
| <PackageVersion Include="xunit" Version="[2.9.3,3.0)" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,3.0)" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,)" /> |
There was a problem hiding this comment.
3.* works only with .NET8 (it is fine) and .NET Framework 4.7.2 (we cannot update to such version).
Is there any option to prevent renovate with updates? If it can be configured. we could change it to
| <PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,)" /> | |
| <PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" /> |
or keep previous version.
There was a problem hiding this comment.
There is no xunit 3.*. There is however xunit.v3 1.*-3.* - it's a completely different package.
This is the latest version for v2, and is unpinned so if there's ever a patch version for it we'll get the update.
There was a problem hiding this comment.
Just noticed the comment was on the other line.
True, but post merge we can just close the PR to ignore the v3 update. We'd still get a patch version of there ever was one for 2.
Branch Conflicted |
Prevent use with 2.0/0.13.
| <PackageVersion Include="Google.Protobuf" Version="[3.22.5,4.0)" /> | ||
| <PackageVersion Include="Grpc" Version="[2.44.0,3.0)" /> | ||
| <PackageVersion Include="Grpc.Net.Client" Version="[2.52.0,3.0)" /> | ||
| <PackageVersion Include="Grpc.AspNetCore" Version="2.59.0" /> |
There was a problem hiding this comment.
I see we're removing upper version constraints across multiple packages. Could you please explain why this is needed.
There was a problem hiding this comment.
So we get pull requests to update them and can then review them.
These are all test dependencies so there shouldn't be any harm in keeping them up to date.
There's more detailed commentary on the changes being made in the linked PR that was originally opened.
Use syntax that would avoid renovate trying to update these versions (see open-telemetry#6459).
Use syntax that would avoid renovate trying to update these versions (see open-telemetry#6459).
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
build/docker-compose.net8.0.yml(docker-compose)build/docker-compose.net9.0.yml(docker-compose).github/workflows/Component.BuildTest.yml(github-actions).github/workflows/add-labels.yml(github-actions).github/workflows/automation.yml(github-actions).github/workflows/ci.yml(github-actions).github/workflows/codeql-analysis.yml(github-actions).github/workflows/concurrency-tests.yml(github-actions).github/workflows/docfx.yml(github-actions).github/workflows/dotnet-format.yml(github-actions).github/workflows/fossa.yml(github-actions).github/workflows/markdownlint.yml(github-actions).github/workflows/ossf-scorecard.yml(github-actions).github/workflows/package-validation.yml(github-actions).github/workflows/post-release.yml(github-actions).github/workflows/prepare-release.yml(github-actions).github/workflows/publish-packages-1.0.yml(github-actions).github/workflows/sanitycheck.yml(github-actions).github/workflows/stale.yml(github-actions).github/workflows/survey-on-merged-pr.yml(github-actions).github/workflows/verifyaotcompat.yml(github-actions)Directory.Packages.props(nuget)build/Common.nonprod.props(nuget)build/Common.prod.props(nuget)build/Common.props(nuget)build/Common.targets(nuget)docs/logs/complex-objects/complex-objects.csproj(nuget)docs/metrics/getting-started-aspnetcore/getting-started-aspnetcore.csproj(nuget)docs/trace/getting-started-aspnetcore/getting-started-aspnetcore.csproj(nuget)docs/trace/getting-started-jaeger/getting-started-jaeger.csproj(nuget)global.json(nuget)src/OpenTelemetry.Api.ProviderBuilderExtensions/OpenTelemetry.Api.ProviderBuilderExtensions.csproj(nuget)src/OpenTelemetry.Api/OpenTelemetry.Api.csproj(nuget)src/OpenTelemetry.Exporter.Prometheus.AspNetCore/OpenTelemetry.Exporter.Prometheus.AspNetCore.csproj(nuget)src/OpenTelemetry.Exporter.Prometheus.HttpListener/OpenTelemetry.Exporter.Prometheus.HttpListener.csproj(nuget)src/OpenTelemetry.Extensions.Hosting/OpenTelemetry.Extensions.Hosting.csproj(nuget)src/OpenTelemetry.Shims.OpenTracing/OpenTelemetry.Shims.OpenTracing.csproj(nuget)src/OpenTelemetry/OpenTelemetry.csproj(nuget)test/Benchmarks/Benchmarks.csproj(nuget)test/Directory.Build.targets(nuget)test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/OpenTelemetry.Api.ProviderBuilderExtensions.Tests.csproj(nuget)test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.csproj(nuget)test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests.csproj(nuget)test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests.csproj(nuget)test/OpenTelemetry.Exporter.Zipkin.Tests/OpenTelemetry.Exporter.Zipkin.Tests.csproj(nuget)test/OpenTelemetry.Extensions.Hosting.Tests/OpenTelemetry.Extensions.Hosting.Tests.csproj(nuget)test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/OpenTelemetry.Instrumentation.W3cTraceContext.Tests.csproj(nuget)test/OpenTelemetry.Shims.OpenTracing.Tests/OpenTelemetry.Shims.OpenTracing.Tests.csproj(nuget)test/OpenTelemetry.Tests.Stress/OpenTelemetry.Tests.Stress.csproj(nuget)test/OpenTelemetry.Tests/OpenTelemetry.Tests.csproj(nuget)test/TestApp.AspNetCore/TestApp.AspNetCore.csproj(nuget)Configuration Summary
Based on the default config's presets, Renovate will:
fixfor dependencies andchorefor all others if semantic commits are in use.node_modules,bower_components,vendorand various test/tests (except for nuget) directories.github-actiondigests._VERSIONvariables in Dockerfiles._VERSIONenvironment variables in GitHub Action files.Signed-off-by:to signoff Git commits.🔡 Do you want to change how Renovate upgrades your dependencies? Add your custom config to
renovate.jsonin this branch. Renovate will update the Pull Request description the next time it runs.What to Expect
With your current configuration, Renovate will create 13 Pull Requests:
Bump dotnet monorepo
renovate/nuget/dotnet-monorepomain8.0.209.0.99.0.99.0.99.0.99.0.99.0.99.0.99.0.99.0.99.9.09.0.98.0.69.0.305Bump dependency Google.Protobuf to 3.32.1
renovate/nuget/protobuf-monorepomain3.32.1Bump dependency Grpc to 2.46.6
renovate/nuget/grpc-2.xmain2.46.6Bump dependency Grpc.Tools to 2.72.0
renovate/nuget/grpc.tools-2.xmain2.72.0Bump dependency Microsoft.NET.Test.Sdk to 17.14.1
renovate/nuget/vstest-monorepomain17.14.1Bump dependency NuGet.Versioning to 6.14.0
renovate/nuget/nuget-monorepomain6.14.0Bump dependency Swashbuckle.AspNetCore to 6.9.0
renovate/nuget/swashbuckle-aspnetcore-monorepomain6.9.0Bump grpc-dotnet monorepo to 2.71.0
renovate/nuget/grpc-dotnet-monorepomain2.71.02.71.02.71.0Bump opentelemetry-dotnet-contrib monorepo to 1.12.0
renovate/nuget/opentelemetry-dotnet-contrib-monorepomain1.12.01.12.01.12.0Bump dependency MinVer to v6
renovate/nuget/minver-6.xmain6.0.0Bump dependency RabbitMQ.Client to v7
renovate/nuget/rabbitmq.client-7.xmain7.1.2Bump dependency Swashbuckle.AspNetCore to v9
renovate/nuget/major-swashbuckle-aspnetcore-monorepomain9.0.4Bump dependency ubuntu to v24
renovate/github-actions/ubuntu-24.xmain24.04❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR was generated by Mend Renovate. View the repository job log.