json/config.h: Generalize setting of JSONCPP_OVERRIDE to all compilers #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has been adapted from InsightSoftwareConsortium/ITK@1c86090
jcfr
referenced
this pull request
in KitwareMedical/jsoncpp
Apr 25, 2016
|
+1 |
|
Cc: @cdunn2001 |
|
I'm fine with this in principle, but if there are complaints from VisualStudio users, we might have to revert this. I seem to recall inconsistent definitions for |
|
Thanks for reviewing and integrating 👍 If there are any issues, I will make sure to follow up. Otherwise, if you are willing to change the minimum required CMake version from CMake Let me know if that sounds reasonable. |
|
That might have to wait for 2.0, unfortunately. |
|
Cc: @vovythevov @fedorov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has been adapted from InsightSoftwareConsortium/ITK@1c86090