std::string -> String #424
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template
std::string
asString
.Maybe this is pointless? The issue is not so much the representation of the JSON strings in the API, but rather of serialization. I want to allow users to specify how we translate between internal
char*
and the public representation. Users should be able to supply their own converters:We can provide defaults for
std::string
, but our default would not handle UTF-32, e.g.What to you think? (See #423.)