Skip to content

Conversation

AryamanTomer
Copy link
Contributor

@AryamanTomer AryamanTomer commented Jul 27, 2025

Important: Do not tick a checkbox if you haven’t performed its action.

Before Creating the Pull Request

  • Verify the changes are on a new branch other than master – it should say "compare: branch-name".
  • Start the pull request title with lowercase letters, e.g., add githubusername.md.
  • Add issue number to the end of the pull request title when applicable, e.g., update mi-faq.md (fixes #3264).

After Creating the Pull Request

  • Go to "Commits" tab, make sure the commit username is clickable and linked to your GitHub account correctly.
  • Review the "Files changed" tab to ensure there are no unnecessary files or changes included in the pull request.
  • Verify that the raw.githack preview link is included in the description.
  • Preview the MDwiki rendered changes using the raw.githack link. Ensure it displays as expected without any errors.
  • Drop a link to this pull request in our discord channel.

Description, Screenshots and/or Screencast

I created a text file in a folder so that I can practice creating a pull request.

Raw.Githack Preview Link

https://raw.githack.com/AryamanTomer/AryamanTomer.github.io/add-AryamanTomer-profile/index.html#!pages/vi/profiles/AryamanTomer.md

@Mutugiii
Copy link
Member

Mutugiii commented Jul 28, 2025

2 issues here:

  1. You have old commits from your previous branch. You should have created a new branch on master to address the new issue.
  2. The intention is to have you create a PR addressing the issue that you identified i.e not directly following the github pull request tutorial(only using it as a guide)

Looking through part 7 of step 6 on the wiki, it seems the instructions are not explicit and can be improved.(This is something you can work on as an issue & PR on step 8)

Copy link
Member

@dogi dogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AryamanTomer generally a good start

Comment on lines +1 to +2
This is the content of the file.
This is additional content.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants