Skip to content

chore: improve comments #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2024
Merged

chore: improve comments #445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed1914c
chore: improve comments
Uzlopak Jul 11, 2024
5e52b8a
Merge branch 'main' into improve-comments
Uzlopak Jul 11, 2024
e2cf54b
Merge branch 'main' into improve-comments
wolfy1339 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ export class RequestError extends Error {

this.name = "HttpError";

// Implicit coercion to number if statusCode is a string
// Coerce the statusCode to an integer especially if it is a string
this.status = Number.parseInt(statusCode as unknown as string);

// If status is not equal to itself, then it is NaN
// we set then the status to 0
// If status code is NaN, then set status to 0 to signal e.g. a network
// error or a AbortError
if (Number.isNaN(this.status)) {
this.status = 0;
}
Expand Down