fix(graphql): GraphQL queries can exceed the rate limit even with x-ratelimit-remaining !== 0. #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Oct 24, 2023
jyasskin
changed the title
jyasskin
force-pushed
the
graphql-can-rate-limit-above-0
branch
from
f4b4bbd to
0c5cd08
Compare
|
I've adjusted the tests so they cover this case. Is https://github.com/jyasskin/testing/actions/runs/6630237322/job/18011241976 what you meant by a replicable test case? |
gr2m
reviewed
Oct 25, 2023
|
🎉 This PR is included in version 8.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix #632, but I haven't tested it.