Namespace mapping to database in observer in one HBase client; set RPC connect timeout to Table Client #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to HBase 1.3.6 compatibility, adapting the connection and checkAndMutate features.
* filter * add scan tests
* init bufferedMutator * finish validateFamily and asyncExecute * correct log in OHBufferedMutatorImpl * pass self-test * format code * add retry when batch fails * remove test print * format code * make interface more generalized * format BufferedMutator test case * remove redundancy, add some comments * fix type of a bufferedMutator. Optimize by review
* hbase_multi_column_family_dev * fix * fix revierw
…ceanbase#68) * init bufferedMutator * finish validateFamily and asyncExecute * correct log in OHBufferedMutatorImpl * pass self-test * format code * add retry when batch fails * remove test print * format code * make interface more generalized * format BufferedMutator test case * remove redundancy, add some comments * fix type of a bufferedMutator. Optimize by review * OHBufferedMutator set and use runtimeBatchExecutor in ObTableClient
… into 1_x_comp # Conflicts: # src/main/java/com/alipay/oceanbase/hbase/OHTable.java
* add sql for multi-cf test; fix conflict error * fix buffered mutation family_violation check * Remove multi-family checks for buffered mutations * fix check family empty
…ion (oceanbase#71) * [Fix] checkAndMutate and get/Scan with filter return -5006 when include special character (oceanbase#58) * [Fix] checkAndMutate and get/Scan with filter return -5006 when include special character * [Chore] fix review * [Fix] fix review * [Fix] fix test * [Fix] fix test testScanSessionClean
shenyunlong
reviewed
Oct 11, 2024
| get.addFamily("family_not_exists".getBytes()); | ||
| expectedException.expect(IOException.class); | ||
| expectedException.expectMessage("query table:test family family_not_exists error."); | ||
| // expectedException.expectMessage("query table:n1:test family family_not_exists error."); |
There was a problem hiding this comment.
remove useless comments
There was a problem hiding this comment.
Already removed.
shenyunlong
reviewed
Oct 11, 2024
| assertEquals("test", hTable2.getTableNameString()); | ||
| // assertEquals("n1:test", hTable2.getTableNameString()); | ||
| assertEquals("test", new String(hTable2.getTableName())); | ||
| // assertEquals("n1:test", new String(hTable2.getTableName())); |
There was a problem hiding this comment.
need confirm this comments
There was a problem hiding this comment.
Already removed. Add a new test case file for multi-namespace testing.
|
LGTM |
shenyunlong
added a commit
that referenced
this pull request
Nov 28, 2024
* range relevant filter (#80) * Range relevant filter (#79) * range relevant filter * review * Namespace mapping to database in observer in one HBase client; set RPC connect timeout to Table Client (#78) * finish connection function * hbase 1.x compatibility: filter relevant (#51) * filter * add scan tests * add scan lease test (#53) * support allowPatialResult (#56) * [Chore] use obkv-table-client 1.2.13-SNAPSHOT for testing (#57) * init bufferedMutator * finish validateFamily and asyncExecute * correct log in OHBufferedMutatorImpl * pass self-test * format code * get bugfix * add retry when batch fails * remove test print * format code * make interface more generalized * test (#59) * random row filter (#62) * format BufferedMutator test case * remove redundancy, add some comments * fix (#66) * fix type of a bufferedMutator. Optimize by review * OHBufferedMutator in OBKV Hbase 1_x_comp (#64) * init bufferedMutator * finish validateFamily and asyncExecute * correct log in OHBufferedMutatorImpl * pass self-test * format code * add retry when batch fails * remove test print * format code * make interface more generalized * format BufferedMutator test case * remove redundancy, add some comments * fix type of a bufferedMutator. Optimize by review * hbase_multi_column_family_dev (#67) * hbase_multi_column_family_dev * fix * fix revierw * OHBufferedMutator set and use runtimeBatchExecutor in ObTableClient * OHBufferedMutator set and add runtimeBatchExecutor in ObTableClient (#68) * init bufferedMutator * finish validateFamily and asyncExecute * correct log in OHBufferedMutatorImpl * pass self-test * format code * add retry when batch fails * remove test print * format code * make interface more generalized * format BufferedMutator test case * remove redundancy, add some comments * fix type of a bufferedMutator. Optimize by review * OHBufferedMutator set and use runtimeBatchExecutor in ObTableClient * Bugfix/sql and conflict fixes (#69) * add sql for multi-cf test; fix conflict error * fix buffered mutation family_violation check * Remove multi-family checks for buffered mutations * fix check family empty * [Chore] refresh code from master branch and upgrade table client version (#71) * [Fix] checkAndMutate and get/Scan with filter return -5006 when include special character (#58) * [Fix] checkAndMutate and get/Scan with filter return -5006 when include special character * [Chore] fix review * [Fix] fix review * [Fix] fix test * [Fix] fix test testScanSessionClean * multi-namespace in one HBase client * format code * set rpcConnectTimeout to tableClient * multi-namespace in ocp mode and odp mode * revert self-defined pom xml * use the test as initial testing case * format code * use 'default' database when param_url misses the database parameter * add new test case testing multi-namespace, remove some comments --------- Co-authored-by: stuBirdFly <[email protected]> Co-authored-by: stuBirdFly <[email protected]> Co-authored-by: miyuan-ljr <[email protected]> Co-authored-by: Shen Yunlong <[email protected]> Co-authored-by: DingZhen <[email protected]> * fuzzy (#81) * DependentColumnFilter, singleColumnValueExcludeFilter and single cf setColumnFamilyTimeRange development (#82) * add DepentdentFilter and SingleColumnValueExcludeFilter * add singleColumnValueExcludeFilter and DependentColumnFilter; add test cases and optimize bufferedMutator test cases * add single cf timerange setting in Get * single cf setColumnFamilyTimeRange in Get and Scan * optimize code * report error when setColumnFamilyTimeRange for a column family that is not queryed * correct name * hbase support batch (#84) * Add DeleteFamilyVersion function and corresponding test cases (#85) * add DepentdentFilter and SingleColumnValueExcludeFilter * add singleColumnValueExcludeFilter and DependentColumnFilter; add test cases and optimize bufferedMutator test cases * add single cf timerange setting in Get * single cf setColumnFamilyTimeRange in Get and Scan * optimize code * add DeleteFamilyVersion and test cases * add DeleteFamilyVersion; optimize test cases * add DeleteFamilyVersion test case and pass * format code * delete useless self-defined table * hbase support batchCallBack (#86) * add native hbase test (#90) * BufferedMutator 1.3 batch (#88) * add DepentdentFilter and SingleColumnValueExcludeFilter * add singleColumnValueExcludeFilter and DependentColumnFilter; add test cases and optimize bufferedMutator test cases * remove DeleteFamilyVersion file and move all cases to MultiColumnFamilyTest * adjust bufferdMutatorImpl 1.x to new batch * bufferedMutator do not retry, batch retry in table client * add rpcTimeout and operationTimetout setting in bufferedMutator * clean execBuffer if all commits have succeed * format code * change connectionConfig to local variable; add deprecated interfaces in 1.x * add check null * Correct test case for the multi-cf bug (#100) * add DepentdentFilter and SingleColumnValueExcludeFilter * add singleColumnValueExcludeFilter and DependentColumnFilter; add test cases and optimize bufferedMutator test cases * merge obkv branch-1.3 and correct test case for the mulfi-cf bug * Optimize test case and add sql script for multi-namespace test (#101) * add DepentdentFilter and SingleColumnValueExcludeFilter * add singleColumnValueExcludeFilter and DependentColumnFilter; add test cases and optimize bufferedMutator test cases * merge obkv branch-1.3 and correct test case for the mulfi-cf bug * optimize test case and add sql to create self-defined database * batch compat old server (#106) * refine (#115) * family filter (#83) * fix encode (#111) * fix: Change single column family get operation to sync query (#96) * fix: Change single column family get operation to sync query * fix: resolve Maven build failure * [Fix] dependency conflict (#116) * [Chore] remove the use of sofa common log * add version control (#108) * add test case (#125) --------- Co-authored-by: miyuan-ljr <[email protected]> Co-authored-by: Ziyu Shi <[email protected]> Co-authored-by: Shen Yunlong <[email protected]> Co-authored-by: DingZhen <[email protected]> Co-authored-by: shenyunlong.syl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
One Hbase client can map different namespaces to corresponding databases in oceanbase. Add RPC connection timeout parameter in our Configuration.
Solution Description
Use the same format of namespaces and qualifiers to map to our databases and tables. Like "n1:test" will map to database "n1" and table group "n1:test". The family will become the suffix to form a complete table name in oceanbase.