Skip to content

fix: Makes 404 errors less scary without revealing existence #8441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

fix: Makes 404 errors less scary without revealing existence #8441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/utils/error-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@ const errorMessage = (er, npm) => {
const pkg = er.pkgid.replace(/(?!^)@.*$/, '')

detail.push(['404', ''])
detail.push(['404', '', `'${replaceInfo(er.pkgid)}' is not in this registry.`])
detail.push([
'404',
'',
`The requested resource '${replaceInfo(er.pkgid)}' could not be found or you do not have permission to access it.`,
])

const nameValidator = require('validate-npm-package-name')
const valResult = nameValidator(pkg)
Expand Down
8 changes: 4 additions & 4 deletions tap-snapshots/test/lib/utils/error-message.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Object {
Array [
"404",
"",
"'http://evil:***@npmjs.org/not-found' is not in this registry.",
"The requested resource 'http://evil:***@npmjs.org/not-found' could not be found or you do not have permission to access it.",
],
Array [
"404",
Expand Down Expand Up @@ -58,7 +58,7 @@ Object {
Array [
"404",
"",
"'node_modules' is not in this registry.",
"The requested resource 'node_modules' could not be found or you do not have permission to access it.",
],
Array [
"404",
Expand Down Expand Up @@ -101,7 +101,7 @@ Object {
Array [
"404",
"",
"'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' is not in this registry.",
"The requested resource 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' could not be found or you do not have permission to access it.",
],
Array [
"404",
Expand Down Expand Up @@ -156,7 +156,7 @@ Object {
Array [
"404",
"",
"'yolo' is not in this registry.",
"The requested resource 'yolo' could not be found or you do not have permission to access it.",
],
Array [
"404",
Expand Down
Loading