Skip to content

fix: use recursive rm in ci command and add test case #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix: use recursive rm in ci command and add test case #6054

merged 2 commits into from
Jan 13, 2023

Conversation

jamesshaw1987
Copy link
Contributor

Adds a test to the PR (#6052) that fixes the referenced issue covering repeat uses of the ci command.

References

Fixes #6051

@jamesshaw1987 jamesshaw1987 requested a review from a team as a code owner January 13, 2023 13:21
@jamesshaw1987 jamesshaw1987 changed the title Btl/ci fix fix: use recursive rm in ci command and add test case Jan 13, 2023
@jamesshaw1987 jamesshaw1987 mentioned this pull request Jan 13, 2023
Closed
2 tasks
@lukekarrys lukekarrys merged commit 1c3612c into npm:latest Jan 13, 2023
@lukekarrys
Copy link
Contributor

Thank you @burkel24 and @jamesshaw1987!

@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lukekarrys lukekarrys lukekarrys approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm ci fails with ERR_FS_EISDIR for node_modules/.bin
3 participants
@jamesshaw1987 @lukekarrys @eleonoratennyson