Add support for forward and back mouse buttons #1919
Merged
+120
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This MR should partly fix #1920, but only on chromium. |
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
from
897d269 to
e3195f7
Compare
CendioOssman
requested changes
Nov 28, 2024
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
3 times, most recently
from
31f0bba to
92afabf
Compare
|
With #1921 merged, this PR has been rebased and should now work with both chromium-based browsers and safari. |
CendioOssman
requested changes
Jan 14, 2025
This is needed if we want to use this function elsewhere in our tests.
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
from
92afabf to
8f0a88e
Compare
CendioOssman
requested changes
Jan 14, 2025
This commit implements the extendedMouseButtons pseudo-encoding, which makes it possible to use the forward and back mouse buttons.
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
from
8f0a88e to
e081d14
Compare
CendioOssman
approved these changes
Jan 15, 2025
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the extendedMouseButtons pseudo-encoding, which makes it possible to use the forward and back mouse buttons.
It looks like chromium is the only browser that has support for this currently. See #1918 for more info.
Confirmed that it works with chromium on Mac, Linux and Windows against TigerVNC server.