Addition of a Bloom Filter object #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsaurus
approved these changes
Nov 18, 2017
app/modules/bloom.c
Outdated
| #include "../crypto/sha2.h" | ||
|
|
||
| #if defined(LUA_USE_MODULES_BLOOM) && !defined(SHA2_ENABLE) | ||
| #error Must have SHA2)ENABLE set for BLOOM module |
docs/en/modules/bloom.md
Outdated
|
|
||
|
|
||
| This module implements a bloom filter. This is a probabilistic data structure that is used to test for set membership. There are two operations -- `add` and `check` that allow | ||
| arbitrary strings to be added to the set or tested for set membership. Since this is a probabilistic dta structure, the answer returned can be incorrect. However, |
docs/en/modules/bloom.md
Outdated
|
|
||
| This module implements a bloom filter. This is a probabilistic data structure that is used to test for set membership. There are two operations -- `add` and `check` that allow | ||
| arbitrary strings to be added to the set or tested for set membership. Since this is a probabilistic dta structure, the answer returned can be incorrect. However, | ||
| if the string *is* a member of the set, then the `check` operation will always return `true`. |
There was a problem hiding this comment.
Maybe add a link to https://en.wikipedia.org/wiki/Bloom_filter for further reading.
|
Thanks for fixing those issues 👍 |
crasu
pushed a commit
to crasu/nodemcu-firmware
that referenced
this pull request
Jan 11, 2018
* Initial checkin * Add bloom.md into mkdocs * Added reset and improved info * Update bloom.c * Update bloom.md * Add Wikipedia link
dnc40085
pushed a commit
to dnc40085/nodemcu-firmware
that referenced
this pull request
Mar 3, 2018
* Initial checkin * Add bloom.md into mkdocs * Added reset and improved info * Update bloom.c * Update bloom.md * Add Wikipedia link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175.
devbranch rather than formaster.docs/en/*.This is a fairly simple implementation of a bloom filter object. The limits on how many objects you can store vary based on how much memory is available. However, storing 10,000 objects with a 1 false positive error rate consumes under 8k bytes of memory.