-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Comment out pmsleep and timer_suspend options in user_config.h #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment out pmsleep and timer_suspend options in user_config.h #2064
Conversation
Oops, it looks as is we've missed some conditionals around calling the |
@TerryE that's weird, it compiled fine locally for both float and integer versions |
Doesn't this effectively render the improvements you made in 0844a5d moot and break backwards compatibility? |
What this does is to make the pmSleep functionality disabled by default. Any developer that wants it only needs to uncomment the two The last dev->master drop slipped in some fundamental changes to how our timer work. This was a mistake, IMO; if making these changes configurable but at least not enabled by default to correct this mistake is a break in backwards compatibility, then it's the sort of break that we should still be doing. |
I wasn't trying to suggest this be changed somehow but trying to verify my assessment of the impact. To conclude:
|
In hind sight, why didn't it occur to us that this change should be reflected in the tmr documentation? scratching my head... |
As someone who recently wasted a not insignificant amount of time trying to figure out why calls to node.sleep kept erroring out, I have to say that I concur with the previous comment. |
dev
branch rather than formaster
.This PR comments out
ENABLE_TIMER_SUSPEND
andPMSLEEP_ENABLE
inuser_config.h
.These features currently have some issues that will take some time to resolve and to prevent further delay of the master drop, the features have been disabled in
user_config.h