fix: libuv can return UV_FILE or UV_TTY for FILE_TYPE_CHAR handles #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion! I've merged it and I'll rebase once #180 lands. |
|
It should be OK to rebase this now. |
|
Thanks @cjihrig! This has been rebased now. Cheers 🍻 |
cjihrig
approved these changes
Dec 16, 2022
|
Excellent! We're actually using this through |
|
Oh that's cool. In that case, you won't have to wait for a Node release (which would probably be next year). I'll get a uvwasi release out today. |
|
This is published in v0.0.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uvwasi is used on Windows, it might be used in non-"ConsoleMode" and the
uv_guess_handlefunction can return two different values forFILE_TYPE_CHARbecause of that difference, see https://github.com/libuv/libuv/blob/v1.x/src/win/handle.c#L42-L47This function can also return
UV_FILEin the case ofFILE_TYPE_DISKbut I assume that a disk file will properly stat and there isn't a good way to figure out which one is being returned.This fixes #157 (took me about a month of debugging)