Skip to content

build: remove corepack from release tarballs #59835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

build: remove corepack from release tarballs #59835

merged 1 commit into from
Sep 12, 2025
+2 −0

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Sep 10, 2025

@ljharb ljharb requested a review from aduh95 September 10, 2025 06:33
@ljharb ljharb added semver-major PRs that contain breaking changes and should be released in the next major version. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 10, 2025
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Sep 10, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69165/

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.74%. Comparing base (8ec29f2) to head (3f770dd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59835      +/-   ##
==========================================
- Coverage   88.28%   87.74%   -0.54%     
==========================================
  Files         701      701              
  Lines      206774   206774              
  Branches    39772    39692      -80     
==========================================
- Hits       182545   181431    -1114     
- Misses      16234    17303    +1069     
- Partials     7995     8040      +45

see 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2025
aduh95
aduh95 reviewed Sep 10, 2025
View reviewed changes
@ljharb ljharb added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 10, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 22a864a into nodejs:main Sep 12, 2025
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 22a864a

@ljharb ljharb deleted the corepack-unmake branch September 12, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ljharb @nodejs-github-bot @lpinca @targos @UlisesGascon @aduh95