Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 6, 2024

Have been unable to reproduce the failure locally.

See: #54346

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2024
@jasnell jasnell requested review from mcollina and anonrig September 6, 2024 14:54
@jasnell
Copy link
Member Author

jasnell commented Sep 6, 2024

Hehe, looks like we duplicated some effort @anonrig ;-) ...

Closing in favor of #54802

@jasnell jasnell closed this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (e4fdd0b) to head (7e0838b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54806   +/-   ##
=======================================
  Coverage   87.61%   87.62%           
=======================================
  Files         650      650           
  Lines      182945   182945           
  Branches    35397    35394    -3     
=======================================
+ Hits       160279   160297   +18     
+ Misses      15923    15908   -15     
+ Partials     6743     6740    -3     

see 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants