test: fix WPT runner cutting off inprogress workers #47626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
test
|
Fast-track has been requested by @panva. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
|
Yeah, let's just do that #47627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having reviewed the WPT Reports I have noticed the test count varies, see e.g. here for 19.x, 20.x, and experimental, those are the ones where #47283 has landed.
This fixes the runner so that in progress multi-variant tests don't get cut off on the account of having the same filename.
fast-trackPRs that do not need to wait for 48 hours to land.
because while this bug is in place we're not actually reporting on WPT failures in workers that get terminated.
I've tested this by running wpt report a number of times and getting consistent number of total reported tests.
NB: Having worked with the runner for a bit now I think a bigger refactor is imminent from my side.