Skip to content

buffer: check INSPECT_MAX_BYTES with validateNumber #46599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

buffer: check INSPECT_MAX_BYTES with validateNumber #46599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,10 @@ ObjectDefineProperties(module.exports, {
configurable: true,
enumerable: true,
get() { return INSPECT_MAX_BYTES; },
set(val) { INSPECT_MAX_BYTES = val; },
set(val) {
validateNumber(val, 'INSPECT_MAX_BYTES', 0);
INSPECT_MAX_BYTES = val;
},
},
});

Expand Down
34 changes: 34 additions & 0 deletions test/parallel/test-buffer-set-inspect-max-bytes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict';

require('../common');
const assert = require('assert');
const buffer = require('buffer');

const rangeErrorObjs = [NaN, -1];
const typeErrorObj = 'and even this';

for (const obj of rangeErrorObjs) {
assert.throws(
() => buffer.INSPECT_MAX_BYTES = obj,
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
}
);

assert.throws(
() => buffer.INSPECT_MAX_BYTES = obj,
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
}
);
}

assert.throws(
() => buffer.INSPECT_MAX_BYTES = typeErrorObj,
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
}
);