-
Notifications
You must be signed in to change notification settings - Fork 138
Add agent registration #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kate-osborn
merged 36 commits into
feature/cp-dp-separation
from
feature/agent-registration
Mar 14, 2023
Merged
Add agent registration #449
kate-osborn
merged 36 commits into
feature/cp-dp-separation
from
feature/agent-registration
Mar 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bbe2a7
to
28ce6ac
Compare
pleshakov
suggested changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some merge conflicts, looks like the rebase went wrong
f55c526
to
b6ecbbc
Compare
pleshakov
reviewed
Mar 14, 2023
pleshakov
reviewed
Mar 14, 2023
pleshakov
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
Re-registration of agents after a control plane restart is not possible at this time without introducing major workarounds. Changes will have to be made to the agent. This effort is tracked here: #459