Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

Update with NFR test results for NGF version edge ["oss","plus"]

  • Auto-generated by the NFR tests workflow run 17749103442
  • Tests ran using Docker image tag edge
  • all test(s) ran

@github-actions github-actions bot force-pushed the tests/nfr-tests-edge branch from ed8c4be to 43245fb Compare September 16, 2025 04:09
@sjberman sjberman marked this pull request as ready for review September 16, 2025 14:18
@sjberman sjberman requested a review from a team as a code owner September 16, 2025 14:18
@sjberman
Copy link
Collaborator

TTR images in the scale test were not rendered. We should also remove any unneeded files ourselves. Not sure if we created a ticket to automatically do that?

Regardless, it would be nice to get these merged in just to get a new baseline on our main branch.

@salonichf5
Copy link
Contributor

TTR images in the scale test were not rendered. We should also remove any unneeded files ourselves. Not sure if we created a ticket to automatically do that?

Regardless, it would be nice to get these merged in just to get a new baseline on our main branch.

I fixed that in my PR for NFR tests, really happy to see reduced error logs for these. Wondering why the image issues happened, but I agree we should merge this for baseline.

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Sep 16, 2025
@salonichf5 salonichf5 enabled auto-merge (squash) September 16, 2025 22:36
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.79%. Comparing base (36788a1) to head (1a99ec3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3921      +/-   ##
==========================================
- Coverage   86.82%   86.79%   -0.04%     
==========================================
  Files         128      128              
  Lines       16575    16575              
  Branches       62       62              
==========================================
- Hits        14392    14386       -6     
- Misses       2004     2009       +5     
- Partials      179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5
Copy link
Contributor

Have rebase this manually hopefully pipeline passes and bot is not unhappy

@salonichf5 salonichf5 merged commit 8f774c1 into main Sep 18, 2025
65 of 66 checks passed
@salonichf5 salonichf5 deleted the tests/nfr-tests-edge branch September 18, 2025 17:22
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants