-
Notifications
You must be signed in to change notification settings - Fork 138
Add regex for path matching #3874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @fabian4! Thanks for opening this pull request! |
2202934
to
72227ea
Compare
Hey @fabian4, thanks a lot for your contribution to NGINX Gateway Fabric! I noticed there are still some parts left in this PR—were you looking for initial feedback before continuing development, or are you planning to submit this in parts? |
Hi @salonichf5, thanks a lot for the comment! I kept this PR as a draft since there are still some parts I’d like to finish up. In the meantime, getting some early feedback would be super helpful — that way I can adjust things early and make sure I’m heading in the right direction. Really appreciate your input! |
72227ea
to
54135b5
Compare
c76e809
to
63c06fe
Compare
For sure, we will get some eyes on it. Thank you again for the contribution. |
@fabian4 We'll be sure to review this soon! In the meantime, I ran the pipeline and there are some linting/unit test errors. Also, please be sure to follow this guide for formatting your main commit message and PR description. And please update the release note section the PR description as well, so we can include a notein our CHANGELOG when this ultimately gets released. |
Problem: As regex path matching is missing support for NGF. Solution: Add support for regex path matching, only allow a full path rewrite/redirect after the regex path match. Testing: Add additional unit test case for regex path match.
194ac10
to
ff24ee1
Compare
Proposed changes
Problem: Add regex for path matching
external (regex path match without any head/method/queryparams condition)
Closes #3110
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.