Skip to content

Feat: Add user-provided helm values for additional control plane service labels #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

Feat: Add user-provided helm values for additional control plane service labels #3499

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd48819
Add the option to specify service labels for the nginx gateway contro…
michasHL Jun 11, 2025
a6985ce
Add user-provided helm values for additional control plane service la…
michasHL Jun 11, 2025
02811ec
Ran make generate-all to get the correct changes into the Readme
michasHL Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/nginx-gateway-fabric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,9 @@ The following table lists the configurable parameters of the NGINX Gateway Fabri
| `nginxGateway.readinessProbe.port` | Port in which the readiness endpoint is exposed. | int | `8081` |
| `nginxGateway.replicas` | The number of replicas of the NGINX Gateway Fabric Deployment. | int | `1` |
| `nginxGateway.resources` | The resource requests and/or limits of the nginx-gateway container. | object | `{}` |
| `nginxGateway.service` | The service configuration for the NGINX Gateway Fabric control plane. | object | `{"annotations":{}}` |
| `nginxGateway.service` | The service configuration for the NGINX Gateway Fabric control plane. | object | `{"annotations":{},"labels":{}}` |
| `nginxGateway.service.annotations` | The annotations of the NGINX Gateway Fabric control plane service. | object | `{}` |
| `nginxGateway.service.labels` | The labels of the NGINX Gateway Fabric control plane service. | object | `{}` |
| `nginxGateway.serviceAccount` | The serviceaccount configuration for the NGINX Gateway Fabric control plane. | object | `{"annotations":{},"imagePullSecret":"","imagePullSecrets":[],"name":""}` |
| `nginxGateway.serviceAccount.annotations` | Set of custom annotations for the NGINX Gateway Fabric control plane service account. | object | `{}` |
| `nginxGateway.serviceAccount.imagePullSecret` | The name of the secret containing docker registry credentials for the control plane. Secret must exist in the same namespace as the helm release. | string | `""` |
Expand Down
3 changes: 3 additions & 0 deletions charts/nginx-gateway-fabric/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ metadata:
namespace: {{ .Release.Namespace }}
labels:
{{- include "nginx-gateway.labels" . | nindent 4 }}
{{- if .Values.nginxGateway.service.labels }}
{{ toYaml .Values.nginxGateway.service.labels | indent 4 }}
{{- end }}
{{- if .Values.nginxGateway.service.annotations }}
annotations:
{{ toYaml .Values.nginxGateway.service.annotations | indent 4 }}
Expand Down
6 changes: 6 additions & 0 deletions charts/nginx-gateway-fabric/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,12 @@
"required": [],
"title": "annotations",
"type": "object"
},
"labels": {
"description": "The labels of the NGINX Gateway Fabric control plane service.",
"required": [],
"title": "labels",
"type": "object"
}
},
"required": [],
Expand Down
3 changes: 3 additions & 0 deletions charts/nginx-gateway-fabric/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ nginxGateway:
# -- The annotations of the NGINX Gateway Fabric control plane service.
annotations: {}

# -- The labels of the NGINX Gateway Fabric control plane service.
labels: {}

# -- The serviceaccount configuration for the NGINX Gateway Fabric control plane.
serviceAccount:
# -- Set of custom annotations for the NGINX Gateway Fabric control plane service account.
Expand Down
Loading