Skip to content

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Apr 1, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want to be able to configure multiple gateways

Solution: Allows users to configure multiple gateways

Testing:

  1. Added unit tests and fixed functional tests

Manual testing: tracking it here

Closes #3219
Closes #3213
Closes #1443
Closes #2704

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add support for multiple gateways

@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Apr 1, 2025
@salonichf5 salonichf5 changed the title Add support for multiple gateways Do Not Review: Add support for multiple gateways Apr 1, 2025
@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch from 8b7192b to 33a4cb7 Compare April 2, 2025 16:11
@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch 2 times, most recently from 2e13294 to efd9397 Compare April 7, 2025 09:11
@sjberman sjberman force-pushed the feat/multiple-gateways branch 2 times, most recently from 61c9184 to 896523a Compare April 14, 2025 19:47
@sjberman sjberman changed the title Do Not Review: Add support for multiple gateways Add support for multiple gateways Apr 14, 2025
@sjberman sjberman force-pushed the feat/multiple-gateways branch from 896523a to 0ff8cfa Compare April 14, 2025 19:55
@sjberman sjberman marked this pull request as ready for review April 14, 2025 19:55
@sjberman sjberman requested a review from a team as a code owner April 14, 2025 19:55
@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch from c1dd270 to d4dcee1 Compare April 15, 2025 20:34
@sjberman sjberman force-pushed the feat/multiple-gateways branch from d4dcee1 to c1dd270 Compare April 15, 2025 20:38
@nginx nginx deleted a comment from codecov bot Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 94.49686% with 35 lines in your changes missing coverage. Please review.

Project coverage is 86.69%. Comparing base (6337c97) to head (9c180d5).
Report is 186 commits behind head on change/control-data-plane-split.

Files with missing lines Patch % Lines
internal/mode/static/manager.go 6.66% 14 Missing ⚠️
internal/mode/static/handler.go 88.70% 4 Missing and 3 partials ⚠️
cmd/gateway/commands.go 14.28% 6 Missing ⚠️
...ernal/mode/static/state/dataplane/configuration.go 96.87% 2 Missing and 1 partial ⚠️
...nal/mode/static/nginx/config/policies/validator.go 77.77% 1 Missing and 1 partial ⚠️
internal/mode/static/state/graph/route_common.go 98.24% 1 Missing and 1 partial ⚠️
...rnal/mode/static/state/graph/backend_tls_policy.go 95.83% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3275      +/-   ##
===================================================================
- Coverage                            89.74%   86.69%   -3.06%     
===================================================================
  Files                                  109      125      +16     
  Lines                                11150    14447    +3297     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12525    +2518     
- Misses                                1083     1784     +701     
- Partials                                60      138      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work.

I think once we get conformance tests working and we can run our full suite of all tests, we can get a better feeling of any issues that may have arisen.

@salonichf5
Copy link
Contributor Author

LGTM, nice work.

I think once we get conformance tests working and we can run our full suite of all tests, we can get a better feeling of any issues that may have arisen.

Thank you for helping me.

@bjee19 bjee19 mentioned this pull request Apr 21, 2025
6 tasks
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the PR, just some small things.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Apr 21, 2025
@sjberman sjberman requested a review from bjee19 April 21, 2025 21:38
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, great job! 🚀

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@sjberman sjberman merged commit 773fea0 into change/control-data-plane-split Apr 22, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Apr 22, 2025
@sjberman sjberman deleted the feat/multiple-gateways branch April 22, 2025 13:59
sjberman added a commit that referenced this pull request Apr 23, 2025
Problem: Users want to be able to configure multiple Gateways with a single installation of NGF.

Solution: Support the ability to create multiple Gateways. Routes and policies can be attached to multiple Gateways.

Also fixed conformance tests.

---------

Co-authored-by: Saylor Berman <[email protected]>
sjberman added a commit that referenced this pull request May 6, 2025
Problem: Users want to be able to configure multiple Gateways with a single installation of NGF.

Solution: Support the ability to create multiple Gateways. Routes and policies can be attached to multiple Gateways.

Also fixed conformance tests.

---------

Co-authored-by: Saylor Berman <[email protected]>
sjberman added a commit that referenced this pull request May 14, 2025
Problem: Users want to be able to configure multiple Gateways with a single installation of NGF.

Solution: Support the ability to create multiple Gateways. Routes and policies can be attached to multiple Gateways.

Also fixed conformance tests.

---------

Co-authored-by: Saylor Berman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-notes tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants