Skip to content

Conversation

bateleurX
Copy link
Contributor

@bateleurX bateleurX commented Jun 4, 2022

Proposed changes

Modify playbooks and molecule to support RHEL 9 system.

Additional modification: In RHEL upgrading and downgrading test, 1.21.6-1 is used to both previous and target version, since there is only 1.21.6-1 for RHEL9.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@bateleurX
Copy link
Contributor Author

This test was failed because nginx 1.26.1 is the sole version that released for RHEL 9 at 4, June. Maybe this will be fixed when another version will be released for RHEL 9.

@bateleurX bateleurX mentioned this pull request Jun 4, 2022
@alessfg
Copy link
Member

alessfg commented Jun 6, 2022

Feel free to tweak the upgrade test for RHEL 9 to only use the latest release. It won't be a comprehensive test but it should do the job for the time being 😄

@alessfg alessfg added the feature label Jun 6, 2022
@alessfg alessfg added this to the 0.23.2 milestone Jun 6, 2022
@alessfg alessfg linked an issue Jun 6, 2022 that may be closed by this pull request
@bateleurX bateleurX marked this pull request as ready for review June 11, 2022 08:14
@bateleurX bateleurX requested a review from alessfg as a code owner June 11, 2022 08:14
@bateleurX
Copy link
Contributor Author

I modified upgrading and downgrading tests to use 1.21.6 in both origin and destination to pass tests in RHEL9.

Copy link
Member

@alessfg alessfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR! 😄

@alessfg alessfg merged commit 3523d15 into nginx:main Jun 13, 2022
@bateleurX bateleurX deleted the feature/rhel9 branch June 13, 2022 12:26
@bateleurX bateleurX restored the feature/rhel9 branch June 13, 2022 14:44
@bateleurX bateleurX deleted the feature/rhel9 branch June 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for RHEL 9
2 participants