Skip to content

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 9, 2025

Type Before After
File Screenshot From 2025-01-09 12-25-47 Screenshot From 2025-01-09 12-24-12
Folder Screenshot From 2025-01-09 12-25-54 Screenshot From 2025-01-09 12-24-02

@artonge artonge added 2. developing Work in progress enhancement New feature or request javascript Javascript related ticket labels Jan 9, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 9, 2025
@artonge artonge self-assigned this Jan 9, 2025
@artonge artonge force-pushed the artonge/feat/disable_some_files_actions branch from b1ac2f6 to 68abfef Compare January 9, 2025 11:25
@artonge artonge marked this pull request as ready for review January 9, 2025 11:25
@artonge artonge requested a review from skjnldsv January 9, 2025 11:27
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 9, 2025
@artonge artonge force-pushed the artonge/feat/disable_some_files_actions branch from 68abfef to b4ad34f Compare January 9, 2025 11:27
@artonge artonge marked this pull request as draft January 9, 2025 17:01
@artonge artonge added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 9, 2025
@artonge artonge removed the request for review from skjnldsv January 9, 2025 17:01
@artonge artonge force-pushed the artonge/feat/disable_some_files_actions branch from b4ad34f to a79dd9f Compare January 9, 2025 17:03
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.56%. Comparing base (b3b07f6) to head (f841a92).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/files.ts 0.00% 17 Missing ⚠️
src/services/downloadUnencryptedAction.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   38.06%   37.56%   -0.50%     
==========================================
  Files          33       33              
  Lines        1429     1448      +19     
  Branches       76       76              
==========================================
  Hits          544      544              
- Misses        883      902      +19     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artonge artonge force-pushed the artonge/feat/disable_some_files_actions branch from a79dd9f to b2b48d2 Compare January 15, 2025 09:13
@artonge artonge marked this pull request as ready for review January 15, 2025 10:52
@artonge artonge force-pushed the artonge/feat/disable_some_files_actions branch from b2b48d2 to f841a92 Compare January 15, 2025 10:52
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 15, 2025
@artonge artonge requested review from nfebe and skjnldsv January 15, 2025 10:54
@skjnldsv
Copy link
Member

Add some tests? 🙈
Cypress probably not needed, vitest should be easy enough :)

@artonge
Copy link
Collaborator Author

artonge commented Jan 15, 2025

Add some tests? 🙈 Cypress probably not needed, vitest should be easy enough :)

Given that it is mostly touching global state, cypress tests would have been more suited, but I am waiting until setting up e2ee from the browser is doable before introducing them.

@artonge artonge merged commit 8b363c5 into master Jan 15, 2025
43 of 45 checks passed
@artonge artonge deleted the artonge/feat/disable_some_files_actions branch January 15, 2025 11:07
@skjnldsv
Copy link
Member

Whichever works for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants