Skip to content

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 8, 2025

Validate the metadata against the received x-nc-e2ee-signature

@artonge artonge added 3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket labels Jan 8, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 8, 2025
@artonge artonge requested review from nfebe and skjnldsv January 8, 2025 16:30
@artonge artonge self-assigned this Jan 8, 2025
@artonge artonge added enhancement New feature or request and removed bug Something isn't working labels Jan 8, 2025
@artonge artonge force-pushed the artonge/feat/validate_user_public_keys branch 3 times, most recently from 25c43be to 3704510 Compare January 8, 2025 16:55
@artonge artonge force-pushed the artonge/feat/validate_metadata_signature branch from e23d018 to 97672f3 Compare January 8, 2025 16:59
@artonge artonge changed the base branch from artonge/feat/validate_user_public_keys to artonge/feat/support_more_mneomonic January 8, 2025 16:59
@artonge artonge force-pushed the artonge/feat/validate_metadata_signature branch from 97672f3 to 54bafcd Compare January 8, 2025 17:00
@artonge artonge force-pushed the artonge/feat/support_more_mneomonic branch from 3fc7f13 to 37551bf Compare January 9, 2025 09:41
@artonge artonge force-pushed the artonge/feat/validate_metadata_signature branch 2 times, most recently from e0ebb57 to 120a34e Compare January 9, 2025 11:08
@nfebe
Copy link

nfebe commented Jan 9, 2025

Lint.

@artonge artonge force-pushed the artonge/feat/support_more_mneomonic branch from 37551bf to b6a7c27 Compare January 9, 2025 17:14
@artonge artonge force-pushed the artonge/feat/validate_metadata_signature branch 2 times, most recently from ef9a9d8 to 02ef8b0 Compare January 13, 2025 09:25
@artonge artonge force-pushed the artonge/feat/support_more_mneomonic branch 2 times, most recently from 7a9e8ed to 371bde1 Compare January 13, 2025 11:51
Base automatically changed from artonge/feat/support_more_mneomonic to master January 13, 2025 12:00
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/validate_metadata_signature branch from 02ef8b0 to bb7c011 Compare January 13, 2025 12:24
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.07%. Comparing base (0df5031) to head (bb7c011).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/services/api.ts 58.82% 7 Missing ⚠️
src/services/crypto.ts 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   26.34%   28.07%   +1.72%     
==========================================
  Files          30       30              
  Lines        1336     1382      +46     
  Branches       37       44       +7     
==========================================
+ Hits          352      388      +36     
- Misses        981      991      +10     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artonge artonge merged commit a11aa9d into master Jan 13, 2025
42 checks passed
@artonge artonge deleted the artonge/feat/validate_metadata_signature branch January 13, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants