feat: Validate signature of users' certificate in metadata #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
b4209d0 to
7909fac
Compare
5 tasks
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
7909fac to
1304832
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
1304832 to
2b3b907
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
2b3b907 to
25c43be
Compare
artonge
force-pushed
the
artonge/chore/cleanups
branch
from
edadda8 to
7770073
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
2 times, most recently
from
3704510 to
51f8f44
Compare
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
51f8f44 to
b8169d3
Compare
|
/compile / |
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
5584e77 to
1bd3dd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 22.23% 25.90% +3.67%
==========================================
Files 29 30 +1
Lines 1255 1324 +69
Branches 27 32 +5
==========================================
+ Hits 279 343 +64
- Misses 973 978 +5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
nfebe
reviewed
Jan 13, 2025
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
3 times, most recently
from
d4dc308 to
21838f8
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]> Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/validate_user_public_keys
branch
from
21838f8 to
1934d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that the users' certificates are signed by the server's private key