fix(sveltekit): respect user-defined basePath #13176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@theRolento is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The
@auth/sveltekitadapter currently overwrites any user-definedbasePathwith the default/auth. This is caused by an unconditional assignment inpackages/frameworks-sveltekit/src/lib/env.ts.This change replaces the direct assignment (
=) with the nullish coalescing assignment operator (??=).This ensures that a user-provided
basePathin theSvelteKitAuthconfiguration is respected, while still falling back to the default/authif nobasePathis provided. This fixes the issue where users setting a custom path (e.g.,/api/auth) would receive 404 errors because the handler was not listening on the configured route.🧢 Checklist
🎫 Affected issues
Fixes: #11584
📌 Resources