Sorbet needs cmd_cwd

[doits]

Description

This is about the sorbet ls: https://github.com/neovim/nvim-lspconfig/blob/61e5109c8cf24807e4ae29813a3a82b31821dd45/lsp/sorbet.lua

If I open a file while my current working directory isn't the root dir of the project, I get this error:

Sorbet's language server requires a single input directory. However, 0 are configured: []

This happens launching the language server manually, too (srb tc --lsp not in project root).

To fix it, cmd_cwd can be set, for example like this:

vim.lsp.config('sorbet', {
  cmd_cwd = vim.fs.root(0, 'Gemfile')
})

Though I am not sure why this is needed, since it should be set automatically to the root_dir if I am correct (which should be found by root_markers?):

nvim-lspconfig/lua/lspconfig/manager.lua

Lines 118 to 120 in 61e5109

	if not new_config.cmd_cwd and vim.uv.fs_realpath(root_dir) then
	new_config.cmd_cwd = root_dir
	end

And I don't see any other ls config make use of cmd_cwd (can't imagine sorbet is the only ls with this requirement, or is it?).

So is cmd_cwd needed here? Or is there some other issue?

NVIM v0.11.1
Build type: Release
LuaJIT 2.1.1744318430

[justinmk]

Though I am not sure why this is needed, since it should be set automatically to the root_dir if I am correct (which should be found by root_markers?):

from :help lsp :

      • {cmd_cwd}?             (`string`, default: cwd) Directory to launch
                               the `cmd` process. Not related to `root_dir`.

nvim-lspconfig/lua/lspconfig/manager.lua is irrelevant, not used for vim.lsp.config.

regarding this:

vim.lsp.config('sorbet', {
  cmd_cwd = vim.fs.root(0, 'Gemfile')
})

that cmd_cwd will be evaluated once, and depends on whatever random buffer might be open. it's not evaluated for each buffer.

[powerman]

@justinmk There is similar issue with ast_grep: it either should be run inside project dir (which won't happens when we run nvim in one project's dir and later open a file from another project) or get extra --config /another/project/sgconfig.yml args.

How this can be fixed? This won't work (probably because it's too late and cmd is already executed):

        before_init = function(_, config)
            config.cmd_cwd = config.root_dir
        end,

I've also tried to modify cmd_cwd on BufEnter but it looks like this has no effect. Probably original cwd_cwd is cached/copied somewhere and later calls to vim.lsp.config() has no effect. Here is what I tried:

            vim.api.nvim_create_autocmd('BufEnter', {
                group = vim.api.nvim_create_augroup('user.lsp.bufenter', { clear = true }),
                pattern = '*',
                callback = function(ev)
                    vim.lsp.config(
                        'ast_grep',
                        { cmd_cwd = vim.fs.dirname(vim.fs.abspath(ev.file)) }
                    )
                end,
            })

I've even tried to :lcd on BufEnter - does not work either. :pwd shows :lcd works okay, but ast-grep still executes in directory where nvim was started.

[justinmk]

There is no good way of defining a dynamic cmd_cwd in a "config". The plan is perhaps neovim/neovim#32287 (comment)

Meanwhile, doing it like this:

vim.lsp.config('sorbet', {
  cmd_cwd = vim.fs.root(0, 'Gemfile')
})

may be good enough, assuming you don't request the config until you open a buffer that's in your project.

[powerman]

I just accidentally found a workaround:

    ast_grep = {
        reuse_client = function(client, config)
            config.cmd_cwd = config.root_dir
            return client.config.cmd_cwd == config.cmd_cwd
        end,
    },

At a glance it works just fine: I've tried to open files from different projects in any order, restart vim with auto-sessions plugin and a lot of such opened files - all looks good.

Is this hack looks good/safe to you?

[justinmk]

Yeah that's fine. reuse_client is intended for these weird cases.