Skip to content

Conversation

lumjjb
Copy link
Member

@lumjjb lumjjb commented Nov 29, 2018

Signed-off-by: Brandon Lum [email protected]

@lumjjb lumjjb self-assigned this Nov 29, 2018
@InTheCloudDan
Copy link
Collaborator

This is currently breaking with multiple authors:
<meta content="http://0.0.0.0:4000/authors/lumjjbricarkol" property="article:author">

I'll try to take a deeper look at it during my lunch time or tonight to see how to get it sorted and if this schema supports multiple authors. Otherwise may just have to choose first one.

Copy link
Collaborator

@InTheCloudDan InTheCloudDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last commit fixed my concerns.

@sahilsuneja1
Copy link
Contributor

sahilsuneja1 commented Nov 29, 2018

I actually liked not showing authors in the blog. Had more of a team vibe to it. For example, the kata fs bug vuln blog post, had inputs from all of us!

@lumjjb
Copy link
Member Author

lumjjb commented Nov 30, 2018

I think it is nice to show different people writing, it also shows the team vibe in a different sense, that everyone is contributing and are exploring different things in the group. In this way, hopefully we can encourage others in the community to write blog posts too, not just us!

For credit for others' contribution, now that we have multiple authors, we can do that too :).

@sahilsuneja1
Copy link
Contributor

okie dokie :)

@lumjjb lumjjb merged commit b3077e2 into master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants