Skip to content

Conversation

richiejp
Copy link
Collaborator

  • chore(ci): Build modified backends on PR
  • chore(stablediffusion-ggml): rm redundant comment

Description

Presently we have to manually modify the workflow to build backends on a PR. Also without modifying the matrix, all backends get built.

This should only build the backend(s) that was changed in the PR.

Notes for Reviewers

It's more complicated than I would like, but justifiable for a large mono-repo if it works fairly well IMO.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 2b8c7b5
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/68a32050eab62a000880226e
😎 Deploy Preview https://deploy-preview-6086--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@richiejp richiejp force-pushed the chore/backend-pr-workflow branch from 4052ab5 to 0e0f6fb Compare August 18, 2025 10:01
@richiejp richiejp force-pushed the chore/backend-pr-workflow branch from 0e0f6fb to b0c0106 Compare August 18, 2025 10:04
mudler
mudler previously approved these changes Aug 18, 2025
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@richiejp richiejp force-pushed the chore/backend-pr-workflow branch 5 times, most recently from 29e13b0 to 87ea2c3 Compare August 18, 2025 11:14
@richiejp richiejp force-pushed the chore/backend-pr-workflow branch from 87ea2c3 to 2b8c7b5 Compare August 18, 2025 12:45
@richiejp
Copy link
Collaborator Author

GitHub actions kill me xD

Have to be careful that it really ran the workflows before merging

@richiejp
Copy link
Collaborator Author

OK, it looks like it is really doing it!

@mudler mudler merged commit ebd1db2 into mudler:master Aug 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants