feat(backends): add system backend, refactor #6059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
argh, should have been |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| if err != nil { | ||
| log.Error().Err(err).Msgf("error installing backend %s", op.GalleryElementName) | ||
| if !op.Delete { | ||
| // If we didn't install the backend, we need to make sure we don't have a leftover directory | ||
| gallery.DeleteBackendFromSystem(g.appConfig.BackendsPath, op.GalleryElementName) | ||
| gallery.DeleteBackendFromSystem(systemState, op.GalleryElementName) |
Check warning
Code scanning / gosec
Errors unhandled Warning
mudler
force-pushed
the
feat/system-backends
branch
2 times, most recently
from
69d0ded to
c9daca9
Compare
mudler
force-pushed
the
feat/system-backends
branch
3 times, most recently
from
536f166 to
2c190ee
Compare
- Add a system backend path - Refactor and consolidate system information in system state - Use system state in all the components to figure out the system paths to used whenever needed - Refactor BackendConfig -> ModelConfig. This was otherway misleading as now we do have a backend configuration which is not the model config. Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
feat/system-backends
branch
from
2c190ee to
aac0e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LOCALAI_BACKENDS_SYSTEM_PATHor via args). Defaults to/usr/share/localai/backends. This path will be used as read-only and won't be used for installation and deletion of backends.This PR fixes #5917
Notes for Reviewers
Signed commits