Skip to content

really drop python<=3.7 support #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: hg
Choose a base branch
from
Open

really drop python<=3.7 support #529

wants to merge 2 commits into from
+121 −187

Conversation

kloczek
Copy link

@kloczek kloczek commented May 5, 2024

Filter all code over pyupgrade --py38-plus.

kloczek added 2 commits May 5, 2024 07:10
@kloczek
really drop python<=3.7 support
4fb942f 
Filter all code over `pyupgrade --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
@kloczek
drop unused imports
9700616 
Filter code over ruff.

Signed-off-by: Tomasz Kłoczko <[email protected]>
@EpicWink
Copy link

This pull-request is likely not-needed anymore, as the project only supports Python 3.8+

ssbarnea
ssbarnea suggested changes Nov 7, 2024
View reviewed changes
Copy link

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good but it needs a better name: "Use python3.8 newer syntax" as this project already requires py38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ssbarnea ssbarnea ssbarnea requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kloczek @EpicWink @ssbarnea