Skip to content

DRIVERS-3108 skip non-LB test on >=8.1 server #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

DRIVERS-3108 skip non-LB test on >=8.1 server #1758

merged 1 commit into from
Feb 18, 2025

Conversation

kevinAlbs
Copy link
Contributor

Skip the test operations against non-load balanced clusters fail if URI contains loadBalanced=true on >= 8.1. See DRIVERS-3108 for motivation.

Tested in the C driver in this patch. Patch also applies mongodb-labs/drivers-evergreen-tools#607 to test unreleased 8.1 servers. The failure on macOS appears to be a separate issue.

Please complete the following before merging:

  • [ ] Update changelog. Test changes only
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@kevinAlbs kevinAlbs marked this pull request as ready for review February 18, 2025 18:51
@kevinAlbs kevinAlbs requested a review from a team as a code owner February 18, 2025 18:51
@kevinAlbs kevinAlbs requested review from dariakp and blink1073 and removed request for a team and dariakp February 18, 2025 18:51
@blink1073
Copy link
Member

Running a patch build in Python now: https://spruce.mongodb.com/version/67b4d8cb3b14bd0007c52456/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

blink1073
blink1073 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in Python, LGTM!

@kevinAlbs kevinAlbs merged commit d05c33e into mongodb:master Feb 18, 2025
5 checks passed
@kevinAlbs kevinAlbs mentioned this pull request Feb 19, 2025
Merged
kevinAlbs added a commit to kevinAlbs/specifications that referenced this pull request Mar 5, 2025
@kevinAlbs
Revert "DRIVERS-3108 skip non-LB test on >=8.1 server (mongodb#1758)"
e608d48 
This reverts commit d05c33e.
@kevinAlbs kevinAlbs mentioned this pull request Mar 5, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinAlbs @blink1073