test(NODE-7160): migrate node-mongodb-native/test/unit/assorted tests
#4663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Sep 17, 2025
There was a problem hiding this comment.
From the test refactor ticket:
Update the client import in each updated file to use src instead of legacy
Can we also update each file in this directory to import from src, instead of from ../../mongodb?
Additionally, going forward, can we put any JS->TS conversions into their own commit? That helps with review, because you can then view the diff on subsequent commits to see the substantive changes. The diff in this PR is unhelpful
baileympearson
added
the
Primary Review
dariakp
changed the title
node-mongodb-native/test/unit/assorted testsnode-mongodb-native/test/unit/assorted tests
|
@PavelSafronov Just a note that I updated the conventional commit tag in the PR title to "test". We reserve "fix" for bug fixes of source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Migrating
node-mongodb-native/test/unit/assorteddriver callback API style tests to promises.Notes for Reviewers
Repro/test steps:
test/mongodb.ts(this disables MongoDB legacy)npm run check:unittest/unit/assorted/sessions_client.test.tsnpm run check:unittest/unit/assorted/sessions_client.test.tstest/mongodb.tsnpm run check:unitWhat is the motivation for this change?
https://jira.mongodb.org/browse/NODE-4979
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript