Skip to content

Remove Python 2 compatibility SON methods #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −14
Open

Remove Python 2 compatibility SON methods #2548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions bson/son.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,6 @@ def copy(self) -> SON[_Key, _Value]:
def __iter__(self) -> Iterator[_Key]:
yield from self.__keys

def has_key(self, key: _Key) -> bool:
return key in self.__keys

def iterkeys(self) -> Iterator[_Key]:
return self.__iter__()

# fourth level uses definitions from lower levels
def itervalues(self) -> Iterator[_Value]:
for _, v in self.items():
yield v

def values(self) -> list[_Value]: # type: ignore[override]
return [v for _, v in self.items()]

Expand Down
4 changes: 1 addition & 3 deletions test/test_son.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,12 @@ def test_iteration(self):
for ele in test_son:
self.assertEqual(ele * 100, test_son[ele])

def test_contains_has(self):
def test_contains(self):
"""has_key and __contains__"""
test_son = SON([(1, 100), (2, 200), (3, 300)])
self.assertIn(1, test_son)
self.assertIn(2, test_son, "in failed")
self.assertNotIn(22, test_son, "in succeeded when it shouldn't")
self.assertTrue(test_son.has_key(2), "has_key failed")
self.assertFalse(test_son.has_key(22), "has_key succeeded when it shouldn't")

def test_clears(self):
"""Test clear()"""
Expand Down
Loading