PHPLIB-1116: Add tests for runCommand spec #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This PR should wait on mongodb/specifications#1410. |
alcaeus
approved these changes
Apr 24, 2023
Comment on lines
+689
to
+694
| /* runCommand spec tests may execute commands that return a | ||
| * cursor (e.g. aggregate). PHPC creates a cursor automatically | ||
| * so cannot return the original command result. Existing spec | ||
| * tests do not evaluate the result, so we can return null here. | ||
| * If that changes down the line, we can use command monitoring | ||
| * to capture and return the command result. */ |
|
Updated with follow-up commit for DRIVERS-2577: mongodb/specifications@146964a Will merge after CI completes. |
4 tasks
|
Found a separate issue with the spec tests, so this will need to wait on mongodb/specifications#1416 to be resolved. Pushing a POC commit in the meantime. |
jmikola
force-pushed
the
phplib-1116
branch
2 times, most recently
from
848b948 to
69d507f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1116
Opening this PR preemptively as I noticed some test runner changes were necessary to POC mongodb/specifications#1389. This PR will be updated once the spec is merged and we have a final sync commit.