Skip to content

Conversation

vbabanin
Copy link
Member

Comment on lines +361 to +364
/**
* Not a prose spec test. However, it is additional test case for better coverage.
*/
@Test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unified tests validate the raw BsonDocument returned from a MongoCursor, while these prose tests add additional integration coverage for working with ChangeStreamDocument.

@vbabanin vbabanin requested review from a team and katcharov and removed request for a team June 10, 2025 22:40
@vbabanin vbabanin self-assigned this Jun 10, 2025
Copy link
Collaborator

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that ChangeStreamDocumentCodec#OPERATION_TYPE_CODEC is unused and so OperationTypeCodec is dead code. Should we remove both (in this PR or a subsequent one)?

@vbabanin
Copy link
Member Author

Just noticed that ChangeStreamDocumentCodec#OPERATION_TYPE_CODEC is unused and so OperationTypeCodec is dead code. Should we remove both (in this PR or a subsequent one)?

Good catch! I crated a separate PR for removing unused codec: #1746

@vbabanin vbabanin requested a review from jyemin June 20, 2025 23:46
@vbabanin vbabanin requested a review from a team as a code owner June 20, 2025 23:51
@vbabanin vbabanin merged commit 5caf9ba into mongodb:main Jun 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants