Improve the check in get_open_wiki_files() #1870
Conversation
src/moin/_tests/__init__.py
Outdated
| files = [f for f in proc.open_files() if "wiki" in f.path] | ||
| for file in files: | ||
| print(f"open wiki {file}") | ||
| files = [f for f in proc.open_files() if re.search("/cli/wiki/", f.path)] |
There was a problem hiding this comment.
What about passing in the wiki instance path from the configuration and perform a prefix test?
There was a problem hiding this comment.
I wanted to keep the test very simple. The main idea is just to distinguish the wiki data from the logs like “_test_artifacts/server-crawl.log”.
There was a problem hiding this comment.
I wondered about re.search("/cli/wiki/", f.path). I mean is "/cli/wiki/" really correct? To me it is kind of unclear, which open files the function is looking for (data, index, all)?
And if testing for substring containment, I suggest avoiding re.search here und go with "/cli/wiki/" in f.path.
There was a problem hiding this comment.
One part of the path is build here:
moin/src/moin/cli/_tests/conftest.py
Lines 44 to 48 in 9f72fed
giving some path ending with "_test_artifacts/cli/". Inside this dir the wiki is created with subdirectories "wiki/data/" and "wiki/index". But there is another directory called "_test_artifacts/cli2/", so I changed the pattern now.
Fixes #1869.