Fix dump-html: remove item id of links to binary data (#1742) #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. Please create an issue for the .txt file extension problem and link the new PR to it. This helps when searching for issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix the issue with dumping binary content as described in #1742.
While testing dump-html I ran into another issue:
A text file with file extension ".txt" attached as a subitem is being rendered into html content and put into the index.
When the index page is created later on, the href pointing to the text rendered into html still uses the file extension ".txt".
Following such a link in the browser won't render as html page. You will get the raw html text instead.
I will address this issue in a separate PR.