Add FullSearch macro migration for moin1.9 categories #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1585.
The moin1.9 FullSearch macro is used in various situations. One case is the listing of all pages for a specific category. In moin2, the categories are replaced by tags. Therefore, all macro calls related to categories are converted to the moin2 macro ItemList.
In all other cases, the FullSearch macro call is not changed. The same applies to the FullSearchCached macro.
In moin1.9 it is possible to use Categories written as a link, e.g.
In this case the import19 migration keeps the opening brackets in the item and adds the closing brackets to the category name. This is also fixed with this PR.