Skip to content

Multiple php ext dlls #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
+83 −63
Merged

Multiple php ext dlls #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3458e
Let Get-PhpExtensionDetail return the absolute path of DLLs
mlocati Jun 10, 2025
c2cb863
Fix installing pecl_http PHP extension (which includes the raphf PHP …
mlocati Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified PhpManager/private/bin/Inspect-PhpExtension-x64.exe
View file
Open in desktop
Binary file not shown.
Binary file modified PhpManager/private/bin/Inspect-PhpExtension-x86.exe
View file
Open in desktop
Binary file not shown.
135 changes: 74 additions & 61 deletions PhpManager/public/Install-PhpExtension.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
$tempFolder = $null
$finalDllName = $null
$additionalFiles = @()
$newExtensions = @()
try {
if (Test-Path -Path $Extension -PathType Leaf) {
if ($Version -ne '') {
Expand All @@ -95,7 +96,7 @@
throw 'You can''t specify the -MaximumStability argument if you specify an existing file with the -Extension argument'
}
$dllPath = [System.IO.Path]::GetFullPath($Extension)
$newExtension = Get-PhpExtensionDetail -PhpVersion $phpVersion -Path $dllPath
$newExtensions += Get-PhpExtensionDetail -PhpVersion $phpVersion -Path $dllPath
$moveDll = $false
}
else {
Expand Down Expand Up @@ -165,8 +166,17 @@
$dllFiles = @()
}
}
$additionalExtensionsDll = @()
$dllNames = $dllFiles | Where-Object -Property Name -Like "php_*.dll" | Select-Object -ExpandProperty Name
if ($dllNames -is [array] -and $dllNames.Length -eq 2 -and $dllNames -contains 'php_http.dll' -and $dllNames -contains 'php_raphf.dll') {
$newExtensions += Get-PhpExtensionDetail -PhpVersion $phpVersion -Path $(Join-Path -Path $tempFolder -ChildPath 'php_raphf.dll')
$additionalExtensionsDll += 'php_raphf.dll'
}
$dllPath = $null
foreach ($dllFile in $dllFiles) {
if ($additionalExtensionsDll -contains $dllFile.Name) {
continue
}
if ($dllFile.Name -like "php_*.dll") {
if ($dllPath) {
throw ("Multiple PHP DLL found in archive downloaded from {0}" -f $availablePackageVersion.PackageArchiveUrl)
Expand All @@ -184,7 +194,7 @@
$keepDownloadedFile = $true
$dllPath = $downloadedFile
}
$newExtension = Get-PhpExtensionDetail -PhpVersion $phpVersion -Path $dllPath
$newExtensions += Get-PhpExtensionDetail -PhpVersion $phpVersion -Path $dllPath
$moveDll = $true
}
catch {
Expand All @@ -202,73 +212,76 @@
}
}
}
$oldExtension = Get-PhpExtension -Path $phpVersion.ExecutablePath | Where-Object { $_.Handle -eq $newExtension.Handle }
if ($null -ne $oldExtension) {
if ($oldExtension.Type -eq $Script:EXTENSIONTYPE_BUILTIN) {
Write-Verbose ("'{0}' is a builtin extension" -f $oldExtension.Name)
}
Write-Verbose ("Upgrading extension '{0}' from version {1} to version {2}" -f $oldExtension.Name, $oldExtension.Version, $newExtension.Version)
if (-Not(Test-IsFileWritable($oldExtension.Filename))) {
throw "Unable to write to the file $($oldExtension.Filename)"
}
if ($moveDll) {
Move-Item -Path $dllPath -Destination $oldExtension.Filename -Force
} else {
Copy-Item -Path $dllPath -Destination $oldExtension.Filename -Force
}
try {
Reset-Acl -Path $oldExtension.Filename
} catch {
Write-Debug -Message "Failed to reset the ACL for $($oldExtension.Filename): $($_.Exception.Message)"
}
foreach ($additionalFile in $additionalFiles) {
$additionalFileDestination = Join-Path -Path $AdditionalFilesPath -ChildPath $(Split-Path -Path $additionalFile -Leaf)
Copy-Item -LiteralPath $additionalFile -Destination $additionalFileDestination -Force
foreach ($newExtension in $newExtensions) {
$oldExtension = Get-PhpExtension -Path $phpVersion.ExecutablePath | Where-Object { $_.Handle -eq $newExtension.Handle }
if ($null -ne $oldExtension) {
if ($oldExtension.Type -eq $Script:EXTENSIONTYPE_BUILTIN) {
Write-Verbose ("'{0}' is a builtin extension" -f $oldExtension.Name)
}
Write-Verbose ("Upgrading extension '{0}' from version {1} to version {2}" -f $oldExtension.Name, $oldExtension.Version, $newExtension.Version)
if (-Not(Test-IsFileWritable($oldExtension.Filename))) {
throw "Unable to write to the file $($oldExtension.Filename)"
}
if ($moveDll) {
Move-Item -Path $newExtension.Filename -Destination $oldExtension.Filename -Force
} else {
Copy-Item -Path $newExtension.Filename -Destination $oldExtension.Filename -Force
}
try {
Reset-Acl -Path $additionalFileDestination
Reset-Acl -Path $oldExtension.Filename
} catch {
Write-Debug -Message "Failed to reset the ACL for $($additionalFileDestination): $($_.Exception.Message)"
Write-Debug -Message "Failed to reset the ACL for $($oldExtension.Filename): $($_.Exception.Message)"
}
foreach ($additionalFile in $additionalFiles) {
$additionalFileDestination = Join-Path -Path $AdditionalFilesPath -ChildPath $(Split-Path -Path $additionalFile -Leaf)
Copy-Item -LiteralPath $additionalFile -Destination $additionalFileDestination -Force
try {
Reset-Acl -Path $additionalFileDestination
} catch {
Write-Debug -Message "Failed to reset the ACL for $($additionalFileDestination): $($_.Exception.Message)"
}
}
if ($oldExtension.State -eq $Script:EXTENSIONSTATE_DISABLED -and -Not($DontEnable)) {
Enable-PhpExtension -Extension $oldExtension.Name -Path $phpVersion.ExecutablePath
}
}
if ($oldExtension.State -eq $Script:EXTENSIONSTATE_DISABLED -and -Not($DontEnable)) {
Enable-PhpExtension -Extension $oldExtension.Name -Path $phpVersion.ExecutablePath
}
}
else {
Write-Verbose ("Installing new extension '{0}' version {1}" -f $newExtension.Name, $newExtension.Version)
if (-not($NoDependencies)) {
Install-PhpExtensionPrerequisite -Extension $newExtension.Handle -InstallPath $AdditionalFilesPath -PhpPath $phpVersion.ActualFolder
}
if ($null -eq $finalDllName) {
$newExtensionFilename = [System.IO.Path]::Combine($phpVersion.ExtensionsPath, [System.IO.Path]::GetFileName($dllPath))
} else {
$newExtensionFilename = [System.IO.Path]::Combine($phpVersion.ExtensionsPath, [System.IO.Path]::GetFileName($finalDllName))
}
if ($moveDll) {
Write-Verbose "Moving ""$dllPath"" to ""$newExtensionFilename"""
Move-Item -Path $dllPath -Destination $newExtensionFilename
} else {
Write-Verbose "Copying ""$dllPath"" to ""$newExtensionFilename"""
Copy-Item -Path $dllPath -Destination $newExtensionFilename
}
try {
Reset-Acl -Path $newExtensionFilename
} catch {
Write-Debug -Message "Failed to reset the ACL for $($newExtensionFilename): $($_.Exception.Message)"
}
foreach ($additionalFile in $additionalFiles) {
$additionalFileDestination = Join-Path -Path $AdditionalFilesPath -ChildPath $(Split-Path -Path $additionalFile -Leaf)
Copy-Item -LiteralPath $additionalFile -Destination $additionalFileDestination -Force
else {
Write-Verbose ("Installing new extension '{0}' version {1}" -f $newExtension.Name, $newExtension.Version)
if (-not($NoDependencies)) {
Install-PhpExtensionPrerequisite -Extension $newExtension.Handle -InstallPath $AdditionalFilesPath -PhpPath $phpVersion.ActualFolder
}
if ($null -eq $finalDllName) {
$newExtensionFilename = [System.IO.Path]::Combine($phpVersion.ExtensionsPath, [System.IO.Path]::GetFileName($newExtension.Filename))
} else {
$newExtensionFilename = [System.IO.Path]::Combine($phpVersion.ExtensionsPath, [System.IO.Path]::GetFileName($finalDllName))
}
if ($moveDll) {
Write-Verbose "Moving ""$($newExtension.Filename)"" to ""$newExtensionFilename"""
Move-Item -Path $newExtension.Filename -Destination $newExtensionFilename
} else {
Write-Verbose "Copying ""$($newExtension.Filename)"" to ""$newExtensionFilename"""
Copy-Item -Path $newExtension.Filename -Destination $newExtensionFilename
}
try {
Reset-Acl -Path $additionalFileDestination
Reset-Acl -Path $newExtensionFilename
} catch {
Write-Debug -Message "Failed to reset the ACL for $($additionalFileDestination): $($_.Exception.Message)"
Write-Debug -Message "Failed to reset the ACL for $($newExtensionFilename): $($_.Exception.Message)"
}
foreach ($additionalFile in $additionalFiles) {
$additionalFileDestination = Join-Path -Path $AdditionalFilesPath -ChildPath $(Split-Path -Path $additionalFile -Leaf)
Copy-Item -LiteralPath $additionalFile -Destination $additionalFileDestination -Force
try {
Reset-Acl -Path $additionalFileDestination
} catch {
Write-Debug -Message "Failed to reset the ACL for $($additionalFileDestination): $($_.Exception.Message)"
}
}
if (-Not($DontEnable)) {
Write-Verbose "Enabling extension ""$($newExtension.Name)"" for ""$($phpVersion.ExecutablePath)"""
Enable-PhpExtension -Extension $newExtension.Name -Path $phpVersion.ExecutablePath
}
}
if (-Not($DontEnable)) {
Write-Verbose "Enabling extension ""$($newExtension.Name)"" for ""$($phpVersion.ExecutablePath)"""
Enable-PhpExtension -Extension $newExtension.Name -Path $phpVersion.ExecutablePath
}
$additionalFiles = @()
}
}
finally {
Expand Down
11 changes: 9 additions & 2 deletions src/Inspect-PhpExtension.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,14 @@ void parseDll(HMODULE hModule, extensionInfo* extensionInfo)

void parseFile(LPCSTR filename, LPCSTR architecture)
{
HMODULE hModule = LoadLibraryEx(filename, NULL, DONT_RESOLVE_DLL_REFERENCES);
DWORD rc;
TCHAR fullpath[MAX_PATH];
rc = GetFullPathName(filename, MAX_PATH, fullpath, NULL);
if (rc == 0 || rc > MAX_PATH) {
printf("Unable to determine the absolute path of the file %s\n", filename);
return;
}
HMODULE hModule = LoadLibraryEx(fullpath, NULL, DONT_RESOLVE_DLL_REFERENCES);
if (hModule == NULL) {
printf("Unable to open the DLL.\n");
} else {
Expand All @@ -162,7 +169,7 @@ void parseFile(LPCSTR filename, LPCSTR architecture)
extensionInfo.type,
extensionInfo.name == NULL ? "" : extensionInfo.name,
extensionInfo.version == NULL ? "" : extensionInfo.version,
filename
fullpath
);
}
FreeLibrary(hModule);
Expand Down