Add support for multiple images and videos in response methods #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `respond` and `streamResponse` methods to accept `[UserInput.Image]?` and `[UserInput.Video]?` arrays. - Added overloads to maintain backward compatibility with existing single `image` and `video` parameters. - Simplified internal logic using default empty arrays for nil values, improving code readability and flexibility.
- Changed parameters from `UserInput.Image?` and `UserInput.Video?` to `[UserInput.Image]?` and `[UserInput.Video]?`. - Previously, the method expected arrays internally but accepted single optional inputs, leading to a mismatch. - This fix ensures consistency and prepares for cleaner multi-input support in follow-up refactors.
- Corrected the call to the main async `respond` method by adding `try await`. - Prevents async runtime errors and ensures the method correctly propagates asynchronous execution and error handling.
|
I implemented it using my repo and branch on my XCode project and it worked well. |
- Changed `images` and `videos` parameters in `respond` and `streamResponse` methods to be non-optional. - Removed internal fallback to empty arrays (`?? []`), shifting responsibility to the caller. - Updated doc comments to reflect that these inputs are now required as arrays. - Clarifies the method contract and simplifies internal logic by eliminating conditional handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respondandstreamResponsemethods to accept[UserInput.Image]and[UserInput.Video]arrays.imageandvideoparameters.