Add Falcon H1 #336
Draft
Add Falcon H1 #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
reviewed
Jun 24, 2025
|
|
||
| // MARK: - Mamba2Cache KVCache | ||
|
|
||
| private class Mamba2Cache: KVCache { |
There was a problem hiding this comment.
There is now a:
/// Simple cache for Mamba-style state space models
public class MambaCache: BaseKVCache {added in #334 -- will that work for this? If not, would it make sense to move Mamba2Cache into KVCache.swift?
There was a problem hiding this comment.
No problem, I need to take some time to study #334.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports Falcon H1.
Thanks to my idol @Blaizzy !
Source: ml-explore/mlx-lm#231