Skip to content

Add a "+" sign after version number and total size if there are more than 20 versions #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2025
Merged

Add a "+" sign after version number and total size if there are more than 20 versions #3569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8731637
Add a "+" sign to show there are more than 20 versions of an object
nicolus Aug 2, 2025
496a628
Merge branch 'minio:master' into show-when-more-than20-versions
nicolus Aug 2, 2025
7755fcf
Merge branch 'master' into show-when-more-than20-versions
bexsoft Sep 5, 2025
5ca34e6
Lint files
Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion web-app/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ObjectDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ const ObjectDetailPanel = ({
const [deleteOpen, setDeleteOpen] = useState<boolean>(false);
const [previewOpen, setPreviewOpen] = useState<boolean>(false);
const [totalVersionsSize, setTotalVersionsSize] = useState<number>(0);
const [moreVersionsThanLimit, setMoreVersionsThanLimit] =
useState<boolean>(false);
const [longFileOpen, setLongFileOpen] = useState<boolean>(false);
const [metaData, setMetaData] = useState<any | null>(null);
const [loadMetadata, setLoadingMetadata] = useState<boolean>(false);
Expand Down Expand Up @@ -154,10 +156,14 @@ const ObjectDetailPanel = ({
.listObjects(bucketName, {
prefix: internalPaths,
with_versions: distributedSetup,
limit: 21,
})
.then((res) => {
const result: BucketObject[] = res.data.objects || [];
if (distributedSetup) {
setMoreVersionsThanLimit(result.length > 20);
result.splice(20);

setAllInfoElements(result);
setVersions(result);

Expand Down Expand Up @@ -573,8 +579,11 @@ const ObjectDetailPanel = ({
<Box className={"detailContainer"}>
<strong>Versions:</strong>
<br />
{versions.length} version{versions.length !== 1 ? "s" : ""},{" "}
{versions.length}
{moreVersionsThanLimit ? "+" : ""} version
{versions.length !== 1 ? "s" : ""},{" "}
{niceBytesInt(totalVersionsSize)}
{moreVersionsThanLimit ? "+" : ""}
</Box>
)}
{selectedVersion === "" && (
Expand Down
14 changes: 12 additions & 2 deletions web-app/src/screens/Console/Buckets/ListBuckets/Objects/ObjectDetails/VersionsNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ const VersionsNavigator = ({
const [actualInfo, setActualInfo] = useState<BucketObject | null>(null);
const [objectToShare, setObjectToShare] = useState<BucketObject | null>(null);
const [versions, setVersions] = useState<BucketObject[]>([]);
const [moreVersionsThanLimit, setMoreVersionsThanLimit] =
useState<boolean>(false);
const [restoreVersionOpen, setRestoreVersionOpen] = useState<boolean>(false);
const [restoreVersion, setRestoreVersion] = useState<BucketObject | null>(
null,
Expand Down Expand Up @@ -124,10 +126,14 @@ const VersionsNavigator = ({
.listObjects(bucketName, {
prefix: internalPaths,
with_versions: distributedSetup,
limit: 21,
})
.then((res) => {
const result = get(res.data, "objects", []);

setMoreVersionsThanLimit(result.length > 20);
result.splice(20);

// Filter the results prefixes as API can return more files than expected.
const filteredPrefixes = result.filter(
(item: BucketObject) => item.name === internalPaths,
Expand Down Expand Up @@ -423,12 +429,16 @@ const VersionsNavigator = ({
<Fragment>
<span className={"detailsSpacer"}>
<strong>
{versions.length} Version
{versions.length}
{moreVersionsThanLimit ? "+" : ""} Version
{versions.length === 1 ? "" : "s"}&nbsp;&nbsp;&nbsp;
</strong>
</span>
<span className={"detailsSpacer"}>
<strong>{niceBytesInt(totalSpace)}</strong>
<strong>
{niceBytesInt(totalSpace)}
{moreVersionsThanLimit ? "+" : ""}
</strong>
</span>
</Fragment>
}
Expand Down
4 changes: 3 additions & 1 deletion web-app/src/screens/Console/Menu/MenuWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ const MenuWrapper = () => {
<MenuItem
name={"Documentation"}
icon={<DocumentationIcon />}
path={"https://docs.min.io/community/minio-object-store/index.html?ref=con"}
path={
"https://docs.min.io/community/minio-object-store/index.html?ref=con"
}
/>
<MenuItem
name={"License"}
Expand Down
3 changes: 2 additions & 1 deletion web-app/src/screens/LoginPage/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ const Login = () => {
);
}

let docsURL = "https://docs.min.io/community/minio-object-store/index.html?ref=con";
let docsURL =
"https://docs.min.io/community/minio-object-store/index.html?ref=con";

useEffect(() => {
dispatch(setHelpName("login"));
Expand Down
Loading