Add ReleaseStatic configuration to WinGetServer project #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each vcpkg port can only be installed with a single triplet at a time (in a given install directory). Since we have different triplets for static and non-static configurations, we need to ensure that all projects use the same triplet for a given solution configuration.
This PR adds the ReleaseStatic configuration to the WinGetServer project and sets the solution to use that when appropriate. It also includes a bit of deduplication in the vcxproj.
Having WinGetServer use the triplet for the non-static configuration when building for static, is causing errors in the internal build because it deletes some of the installed triplets that other projects later try to consume.
Microsoft Reviewers: Open in CodeFlow